New feature

robert · Post by **robert** » Thu Jul 29, 2021 3:40 pm

We have received some requests if we could add the entity separator lines in the VS editor.
Today I have implemented that (and yes I am also working on performance improvements as promised)

: Seperators.png (32.33 KiB) Viewed 790 times

I have a few questions:
- Should this be "always on" or do you want to be able to enable/disable this
- As you can see in the image I am now visually including the XML comments before the entity and I am adding the separator line before the XML comments. Is this also what you would want to do.
Or should this also be an option ?

I know that XIDE does not put the separator line before the XML comments.

I would appreciate your feedback.

Robert

xinjie · Post by **xinjie** » Fri Jul 30, 2021 2:44 am

I think it would be better to have a switch to control whether to show the entity separator lines or not.

A little extravagance: can I define the "format" of entity separator lines? For example: I like to use "*********************"

leon-ts · Post by **leon-ts** » Fri Jul 30, 2021 5:57 am

Robert,
My opinion is that it is necessary to give the option to enable/disable it and give the color of this dividing line to be adjusted. In this case, it will be possible to make it dim so that it is present on one side, and on the other side is not very conspicuous. Well, or completely turn it off if you don't like it.

Best regards,
Leonid

robert · Post by **robert** » Fri Jul 30, 2021 6:44 am

Leonid,
I did not invent a new color for this. I am using the color that is defined in the VS color dialog for "Outlining Margin Vertical Rule". The C# editor support uses that same color.
I will indeed add an option to enable/disable this.
What about the XML comments?
Should the separator line be before that comments or between the comments and the method.
I consider the (optional) attributes as part of the method by the way.

Robert

robert · Post by **robert** » Fri Jul 30, 2021 6:45 am

Xinjie
If you want *************** as delimiters then you can use that in your code of course.
The separators that I am talking about are "virtual".

Robert

FFF · Post by **FFF** » Fri Jul 30, 2021 6:58 am

robert wrote:Leonid,
I consider the (optional) attributes as part of the method by the way.

+1
The idea of a separator is to optically bundle lines which "belong" to each other - and the /// certainly DON'T belong to the previous entity

leon-ts · Post by **leon-ts** » Fri Jul 30, 2021 7:35 am

robert wrote: Should the separator line be before that comments or between the comments and the method.

My opinion is definitely before the comment. After all, a comment is essentially a part of one whole with the function it describes.

Best regards,
Leonid

Serggio · Post by **Serggio** » Fri Jul 30, 2021 7:40 am

Sure, the feature is nice! And definitely before the XML comments as those are part of function definition.

Chris · Post by **Chris** » Fri Jul 30, 2021 9:26 am

Robert,

I wish you didn't give me challenges at 40C, but now also XIDE (optionally) puts the separator before the XML tags

Btw, I personally prefer showing the line separators to be optional. Always showing them before the XML tags is probably fine.
Oh, and very nice new feature those entity separators in VS! I know it's a lot more complicated implementing this in VS than it was doing it in XIDE.

: XIDE_entity_sep.png (118.93 KiB) Viewed 787 times

VR · Post by VR » Fri Jul 30, 2021 10:00 am

An option to enable/disable his feature would be nice. But the default IMHO should be enabled.
And since the XML Comments are for the following method, the separator should be before the XML Comments.

Best regards
Volkmar

Main menu